Conversation
valeriabarra
previously requested changes
Nov 20, 2025
Collaborator
Author
|
I believe issue #239 is what's causing the last of the fails |
jbrzensk
reviewed
Dec 2, 2025
Collaborator
jbrzensk
left a comment
jbrzensk
left a comment
There was a problem hiding this comment.
Thanks @bewagner1 for this. I added some notes to the first example, which can be applied to the others.
The docs have some small nitpick items. The code as well. Basically, if something is constant, declare it as such.
For the armadillo vectors and matrices, call them as arma::vec or arma::mat so the reader knows, even though mole uses the armadillo namespace.
I checked the solutions, they seem on par with the MATLAB. You need to add some text about what the output is. See the comment in the code.
Thanks Ben!!
jbrzensk
approved these changes
Dec 5, 2025
jbrzensk
dismissed
valeriabarra’s stale review
Requested changes were addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR contains the current Sturm-Liouville Matlab examples now implemented in C++ along with updated documentation for all Sturm-Liouville examples.
Related Issues & Documents
QA Instructions, Screenshots, Recordings
My machine is an M1 MacBook Pro. The norms of the difference between the MOLE solution and exact solution are the same as in the Matlab implementation.
Added/updated tests?
_We encourage you to test all code included with MOLE, including examples.
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?